Use the window.imagePath global for the base image path in examples if present.#637
Merged
cdcabrera merged 1 commit intopatternfly:masterfrom Sep 28, 2017
Merged
Conversation
| <file name="script.js"> | ||
| angular.module( 'patternfly.card' ).controller( 'CardDemoCtrl', function( $scope ) { | ||
| angular.module( 'patternfly.card' ).controller( 'CardDemoCtrl', function( $scope, $window ) { | ||
| var imagePath = $window.IMAGE_PATH || "img"; |
Member
There was a problem hiding this comment.
we should be consistent and use '/img'
Member
Author
There was a problem hiding this comment.
I was preserving what was previously present. Would you say img is expected to be correct over /img
Member
There was a problem hiding this comment.
yeah, I would say 'img' is probably better, I'd just rather see consistency.
Member
Author
There was a problem hiding this comment.
Done. Standardised on img.
| function ($scope) { | ||
| angular.module('patternfly.navigation').controller('applicationLauncherController', ['$scope', '$window', | ||
| function ($scope, $window) { | ||
| $scope.imagePath = $window.IMAGE_PATH || "img"; |
Member
Author
There was a problem hiding this comment.
...again, I was preserving what was previously present. Happy to converge on a single path with this PR though.
jeff-phillips-18
approved these changes
Sep 28, 2017
…ath in examples if present.
cdcabrera
approved these changes
Sep 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows that patternfly.org site to override the image path used in some examples by specifying the IMAGE_PATH global variable.